Re: [PATCH] forcedeth: fix random memory scribbling bug

[Jeff Garzik]

Manfred Spraul wrote:
> Two critical bugs were found in forcedeth 0.47:
> - TSO doesn't work.
> - pci_map_single() for the rx buffers is called with size==0. This bug 
> is critical, it causes random memory corruptions on systems with an iommu.
>
> Below is a minimal fix for both bugs, for inclusion into 2.6.15.
> TSO will be fixed properly in the next version.
> Tested on x86-64.
>
> Signed-Off-By: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>

1) Why does forcedeth require a non-standard calculation for each 
pci_map_single() call?

2) I have requested multiple times that you avoid MIME...

3) Why disable TSO completely?  It sounds like it should default to off, 
then permit enabling via ethtool.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/