Re: Problem due to removing ppc64 rtc.c?

[Sripathi Kodi]

On Tue, 27 Dec 2005, Benjamin Herrenschmidt wrote:

> On Tue, 2005-12-27 at 15:45 +0530, Sripathi Kodi wrote:
>
> > Before your changes,  rtc_ioctl was implemented in the PPC  specific rtc.c and
> > it used  to call ppc_md.get_rtc_time  for RTC_RD_TIME,  which I think  used to
> > end  up  in  rtas_get_rtc_time.  After  your changes,  time  is  now  read  in
> > rtc_get_rtc_time using CMOS_READ calls, which apparently is resulting in wrong
> > values being  read. I changed  rtc_do_ioctl to make it  call rtas_get_rtc_time
> > for RTC_RD_TIME call and the problem went away.
> >
> > Have I  missed something or  does this  need fixing? Do  we really need  a PPC
> > specific rtc_ioctl call that calls into rtas_get_rtc_time?
>
> I think the problem is that you still have CONFIG_RTC in your .config
> instead of CONFIG_GEN_RTC
>
> Ben.

Yes, that was indeed the problem. Thanks a lot.

-Sripathi.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/