Re: [PATCH 2.6.15-rc7] udf/balloc.c : Fix use of uninitialized data

[Parag Warudkar]

Forgot to add Signed-off-by - corrected patch follows -

Signed-off-by: Parag Warudkar <parag.warudkar@xxxxxxxxx>

Variable goal_eloc is automatic, non-static and initialized conditionally.
 The following patch fixes this by initializing the goal_eloc variable to zero.
Hopefully zero should be better than some random data! (Patch also
attached in case of problem with below inline version.) Compile
tested.

--- linux-2.6/fs/udf/balloc.c.orig      2005-12-28 11:53:12.000000000 -0500
+++ linux-2.6/fs/udf/balloc.c   2005-12-28 11:53:19.000000000 -0500
@@ -754,7 +754,8 @@ static int udf_table_new_block(struct su
        uint32_t spread = 0xFFFFFFFF, nspread = 0xFFFFFFFF;
        uint32_t newblock = 0, adsize;
        uint32_t extoffset, goal_extoffset, elen, goal_elen = 0;
-       kernel_lb_addr bloc, goal_bloc, eloc, goal_eloc;
+       kernel_lb_addr bloc, goal_bloc, eloc,
+       goal_eloc = { .logicalBlockNum=0, .partitionReferenceNum=0 } ;
        struct buffer_head *bh, *goal_bh;
        int8_t etype;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/