Re: [patch] latency tracer, 2.6.15-rc7

From: Lee Revell
Date: Fri Dec 30 2005 - 22:59:13 EST


On Fri, 2005-12-30 at 17:39 -0800, Linus Torvalds wrote:
> diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c
> index 48d3bce..b107562 100644
> --- a/kernel/rcupdate.c
> +++ b/kernel/rcupdate.c
> @@ -149,11 +149,10 @@ void fastcall call_rcu_bh(struct rcu_hea
> *rdp->nxttail = head;
> rdp->nxttail = &head->next;
> rdp->count++;
> -/*
> - * Should we directly call rcu_do_batch() here ?
> - * if (unlikely(rdp->count > 10000))
> - * rcu_do_batch(rdp);
> - */
> +
> + if (unlikely(++rdp->count > 100))
> + set_need_resched();
> +
> local_irq_restore(flags);
> }

This increments rdp->count twice - is that intentional?

Also what was the story deal with the commented out code?

Lee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/