Re: [PATCH 1/1] usb/input: Add missing keys to hid-debug.h

From: Vojtech Pavlik
Date: Tue Jan 03 2006 - 14:52:48 EST


On Tue, Jan 03, 2006 at 01:42:31AM -0500, Dmitry Torokhov wrote:
> On Monday 02 January 2006 18:37, Michael Hanselmann wrote:
> > This patch adds the missing keys from input.h to hid-debug.h.
> >
> > Signed-off-by: Michael Hanselmann <linux-kernel@xxxxxxxxx>
>
> Thank you Michael, I will add it to my tree. I still ponder your other
> patch and whether we should employ something like hooks for HID.

We should split HID in two parts - transport and decoding. This would
help in many places:

Bluetooth would be happy, because it uses the same HID protocol
on top of a different transport layer (completely non-USB).

Wacom and many other blacklisted devices would be happy, because
they could use the USB HID transport - no blacklist would be
needed.

Would allow for /dev/usb/rawhid0 style devices, which would give
access to raw HID reports without any parsing done.

Would allow userspace drivers for broken UPS devices (like APC)
without the need for special handling of their bugs in the kernel.

It seems to me it could be almost its own layer, like serio or gameport.
Windows has an API like that.

I don't have the time to do the split myself, but it shouldn't be too
hard.

It would not be the perfect solution for Apple keyboards, because the
patch is simplifies by doing the processing after parsing the reports,
but still, since it would allow for device-specific parsers, it'd be a
reasonable solution for devices that need more special handling than
just a simple quirk.

--
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/