Re: [Patch 6/6] Delay accounting: Connector interface

From: Shailabh Nagar
Date: Tue Jan 03 2006 - 19:41:50 EST


Greg KH wrote:
> On Tue, Jan 03, 2006 at 11:33:40PM +0000, Shailabh Nagar wrote:
>
>>Changes since 11/14/05:
>>
>>- explicit versioning of statistics data returned
>>- new command type for returning per-tgid stats
>>- for cpu running time, use tsk->sched_info.cpu_time (collected by schedstats)
>>
>>First post 11/14/05
>>
>>delayacct-connector.patch
>>
>>Creates a connector interface for getting delay and cpu statistics of tasks
>>during their lifetime and when they exit. The cpu stats are available only if
>>CONFIG_SCHEDSTATS is enabled.
>
>
> Why do you use this when we can send typesafe data through netlink
> messages now?

AFAIK, adding new netlink types was frowned upon which is one of the reasons why
connectors were proposed (besides making it easier to use the netlink interface) ?

> Because of that, I think the whole connector code can be
> deleted :)
>
> Unless I missed something in the connector code that is not present in
> netlink...
>
> thanks,
>
> greg k-h
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/