Re: [PATCH] Limit sendfile() to 2^31-PAGE_CACHE_SIZE bytes withouterror

From: H. Peter Anvin
Date: Wed Jan 04 2006 - 13:41:11 EST


Ulrich Drepper wrote:
Linus Torvalds wrote:

Ok, this patch looks ok, if it's confirmed to unbreak apache.

Yes, sounds reasonable. But I don't think that, as Peter suggested in
another mail, that glibc should automatically wrap the syscall to
provide support for larger sizes. The caller probably should know when
a transfer was cut short.


Agreed; that's exactly what a short return in supposed to do. Since a short return is compatible with the defined API, that's not a problem.

However, this patch only addresses sendfile(), and this is apparently a much more pervasive problem. We need something similar for all the I/O system calls that are affected by this particular issue.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/