Re: [PATCH 08/15] sonypi: Enable ACPI events for Sony laptop hotkeys

[Matthew Garrett]

Ben Collins <bcollins@xxxxxxxxxx> wrote:
> Signed-off-by: Ben Collins <bcollins@xxxxxxxxxx>

This one's a bit of a hack - it pushes Sony hotkey magic stuff through
the ACPI layer for the sake of consistency, despite the fact that
there's not actually any ACPI involved. 

The "right" way is probably actually to push ACPI hotkey events through
the input layer (like the Sony code does without this patch), but that's
currently a bit more awkward to handle in userspace. Since the right
answer here is clearly "Fix userspace", we probably don't want to be
merging this.

(Disclaimer: I wrote it originally because it was easier than fixing
userspace...)
-- 
Matthew Garrett | mjg59-chiark.mail.linux-rutgers.kernel@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/