Re: [PATCH] Debug shared irqs.

[David Woodhouse]

On Thu, 2006-01-05 at 02:19 -0800, Andrew Morton wrote:
> This is going to cause me a ton of grief.  How's about you put it in
> Fedora for a few weeks, get all the drivers debugged first ;)

I'd do that normally, but it's the wrong point in the cycle -- we're
getting ready for Fedora Core 5 at the moment; it's not the time to be
doing such things. We can apply the patch... but we'd have to turn the
config option off :)

What you're seeing is the whole point of the patch, surely? And it _is_
a config option -- people aren't forced to turn it on.

Would it help if we added a printk to make it more obvious what's
happening, which gives the naÃve user the opportunity to turn off the
config option just to get things working again? Somethign along the
lines of "Faking irq %d due to CONFIG_DEBUG_SHIRQ. If your machine
crashes now, don't blame akpm"?

Out of interest, does your i810 patch fix the problem which was reported
in November by Eyal Lebedinsky ("2.6.14.2: repeated oops in i810 init")?

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/