Re: [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver

[Bryan O'Sullivan]

On Wed, 2006-01-04 at 13:26 -0800, Roland Dreier wrote:

> Yes, this might be a good idea.  The "core" driver looks like it is
> suffering from really being several things stuck together.

Yes, this is undoubtedly the case; we developed it organically based on
our evolving needs, and we're only now (maybe a bit belatedly) stepping
back to take a breath and see how things should be logically split out.

> Also, there are APIs in the "core" driver that are only exported for a
> single user outside the driver -- it would probably make sense to move
> that logic directly to where it's used.

Right.  The purpose of the whole ipath_layer.c file has perhaps been
unclear; we've been holding back a network driver that makes use of it,
to keep the size of the review patches down.  Some of the other
verbs-related routines in the core driver are in the process of finding
a new home, as you suggested.

As ever, thanks for the comments.

	<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/