drivers/acpi/scan.c: inconsequent NULL handling
From: Adrian Bunk
Date: Fri Jan 06 2006 - 11:28:13 EST
The Coverity checker found the following:
<-- snip -->
static int
acpi_bus_match (
struct acpi_device *device,
struct acpi_driver *driver)
{
if (driver && driver->ops.match)
return driver->ops.match(device, driver);
return acpi_match_ids(device, driver->ids);
}
<-- snip -->
Either driver can be NULL, in which case the driver->ids is a possible
NULL pointer reference, or it can't, in which case the check whether
it's NULL is superfluous.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/