Re: [linux-dvb-maintainer] [RFC: 2.6 patch] drivers/media/dvb/: possible cleanups

[Michael Krufky]

On 1/7/06, Adrian Bunk <bunk@xxxxxxxxx> wrote:
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 the following unused global functions:
>   - b2c2/flexcop-dma.c: flexcop_dma_control_packet_irq()
>   - b2c2/flexcop-dma.c: flexcop_dma_config_packet_count()
>
> Please review which of these changes do make sense and which conflict
> with pending patches.
>
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> ---
>
>  drivers/media/dvb/b2c2/flexcop-common.h      |    2 -
>  drivers/media/dvb/b2c2/flexcop-dma.c         |    4 ++
>  drivers/media/dvb/b2c2/flexcop-misc.c        |    6 ++--
>  drivers/media/dvb/b2c2/flexcop-reg.h         |    4 --
>  drivers/media/dvb/bt8xx/dst.c                |   19 +++++--------
>  drivers/media/dvb/bt8xx/dst_common.h         |    5 ---
>  drivers/media/dvb/dvb-usb/cxusb.c            |    2 -
>  drivers/media/dvb/dvb-usb/dvb-usb-firmware.c |    8 +++--
>  drivers/media/dvb/dvb-usb/dvb-usb.h          |    1
>  drivers/media/dvb/dvb-usb/vp702x.c           |    6 ++--
>  drivers/media/dvb/dvb-usb/vp702x.h           |    2 -
>  drivers/media/dvb/ttpci/av7110.h             |    2 -
>  drivers/media/dvb/ttpci/av7110_ir.c          |   26 +++++++++----------
>  13 files changed, 38 insertions(+), 49 deletions(-)


Adrian,

At first glance, I already see many collisions with pending
patchsets...  Mauro is getting ready to push a whole bunch of patches
onto the v4l-dvb git tree.

Could you please wait until after those get merged?

Also, I'm not sure about some of the changes here... Hopefully some of
the other DVB guys will have some comments.  I think it's better to
postphone reviewing this until after we merge our new v4l / dvb stuff.

Regards,
Michael Krufky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/