Re: 2.6.15-mm2: alpha broken

[Andrew Morton]

Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>
> alpha Just Broken (TM)
> ----------------------------------------------------------------------------
>   CC      arch/alpha/kernel/asm-offsets.s
> In file included from include/asm/user.h:5,
>                  from include/linux/user.h:1,
>                  from include/linux/kernel.h:16,
>                  from include/linux/spinlock.h:54,
>                  from include/linux/capability.h:45,
>                  from include/linux/sched.h:7,
>                  from arch/alpha/kernel/asm-offsets.c:9:
> include/linux/ptrace.h: In function `ptrace_link':
> include/linux/ptrace.h:100: error: dereferencing pointer to incomplete type
> include/linux/ptrace.h: In function `ptrace_unlink':
> include/linux/ptrace.h:105: error: dereferencing pointer to incomplete type
> make[1]: *** [arch/alpha/kernel/asm-offsets.s] Error 1

This is caused by the inclusion of user.h in kernel.h added by
dump_thread-cleanup.patch.

Fix:

--- 25-alpha/include/linux/kernel.h~dump_thread-cleanup-fix	2006-01-07 15:46:50.000000000 -0800
+++ 25-alpha-akpm/include/linux/kernel.h	2006-01-07 15:47:20.000000000 -0800
@@ -13,7 +13,6 @@
 #include <linux/types.h>
 #include <linux/compiler.h>
 #include <linux/bitops.h>
-#include <linux/user.h>
 #include <asm/byteorder.h>
 #include <asm/bug.h>
 
@@ -48,6 +47,8 @@ extern int console_printk[];
 #define default_console_loglevel (console_printk[3])
 
 struct completion;
+struct pt_regs;
+struct user;
 
 /**
  * might_sleep - annotation for functions that can sleep
@@ -124,7 +125,6 @@ extern int __kernel_text_address(unsigne
 extern int kernel_text_address(unsigned long addr);
 extern int session_of_pgrp(int pgrp);
 
-struct pt_regs;
 extern void dump_thread(struct pt_regs *regs, struct user *dump);
 
 #ifdef CONFIG_PRINTK
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/