Re: [PATCH 3/8] RTC subsystem, sysfs interface

[Alessandro Zummo]

On Sun, 8 Jan 2006 21:02:40 -0500
Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> wrote:

> On Sunday 08 January 2006 18:12, Alessandro Zummo wrote:
> > +static ssize_t rtc_sysfs_show_date(struct class_device *dev, char *buf)
> > +{
> > +       ssize_t retval = -ENODEV;
> > +       struct rtc_device *rtc = to_rtc_device(dev);
> > +       struct rtc_time tm;

 [...]

> ops locking is a mess here. Half of the code accesses it under protection
> of ops_lock while other half is unlocked. I think it would be better if
> that lock was taken in rtc_read_time and friends.

 Good point. I'll move them, thanks.
 

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/