Re: [PATCH 15/15] kconf: Check for eof from input stream.

[Ben Collins]

On Mon, 2006-01-09 at 01:09 +0100, Roman Zippel wrote:
> Hi,
> 
> On Sunday 08 January 2006 22:41, Ben Collins wrote:
> 
> > That's not entirely acceptable. The reason this shows up is if an
> > automatic build is being done, and the config files are not up-to-date,
> > the prefered action is a build failure, not selecting defaults. The
> > reason for my fix was that instead of filling up diskspace with a
> > logfile of kconf's infinite loop, we just exit with an error.
> >
> > Currently, this is the only way to ensure that these issues don't go
> > unnoticed.
> 
> Then something is wrong with your automatic build. If the config needs to be 
> updated and stdin is redirected during a kbuild, it will already abort.

And what should be directed into stdin? Nothing. There should be no
input going into an automated build, exactly because it could produce
incorrect results.

BTW, this is the automatic build that Debian and Ubuntu both use (in
Debian's case, used for quite a number of years). So this isn't
something I whipped up.

Still, the build system shouldn't have to do anything special with stdin
to get the desired result. The code should also not react differently
based on stdin being closed, or being pumped with nul data.

-- 
   Ben Collins <ben.collins@xxxxxxxxxx>
   Developer
   Ubuntu Linux

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/