Re: 2.6.15-mm

[Jesper Juhl]

On 1/9/06, Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
> On Mon, 9 Jan 2006, Jesper Juhl wrote:
> > On 1/9/06, Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
> > >
> > > Remove sg_rb_correct4mmap() and its nasty __put_page()s, which are liable
> > > to do quite the wrong thing.  Instead allocate pages with __GFP_COMP, then
> > > high-orders should be safe for exposure to userspace by sg_vma_nopage(),
> > > without any further manipulations.  Based on original patch by Nick Piggin.
> >
> > Unfortunately that patch doesn't change a thing (except some
> > addresses, but that's exected) :-(
>
> Okay, thanks for trying.  Maybe you need to revert to the 2.6.15
> drivers/scsi/sg.c for now (does that work for you in the 2.6.15-mm2
> kernel?), or you could first try this little patch on 2.6.15-mm2
> (either with or without my earlier patch - which will be wanted,
> but not so urgently).  I've not attempted to review the changes
> in detail, but this change (if no more) looks to be badly needed...
> And it's 2.6.15-git needing the fix, not just -mm.
>
>
> sg_page_malloc clear the data buffer, not that extent of mem_map.
>

Hugh, you're a genious!
I added your small patch on top of your previous one and now
2.6.15-mm2 doesn't crash any more  :-)

Thanks a lot.


2.6.15-mm2 still has a few other problems for me though, which I'll
report in a short while in sepperate threads - a lot easier to
investigate now that the box no longer crashes while running that
kernel :)

Thank you again for your work in fixing this problem.

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/