Re: new time code problem

[George Anzinger]

Thomas Gleixner wrote:
> On Tuesday 10 January 2006 23:58, George Anzinger wrote:
>
> > The 64-bit conversion routine to convert 64-bit nsec time to a time spec.
> > gives an unnormalized result if the value being converted is negative.  I
> > think there are two ways to go about fixing this.  Most systems will give a
> > negative remainder and so need to just normalize.  On the other hand, some
> > systems will use div64 to do the division and, I think, it expects unsigned
> > numbers.  The attached patch uses the conservative approach of expecting
> > the div to be set up for unsigned numbers.
> >
> > I came accross this when one of my tests set a time near 1 Jan 1970, i.e.
> > it is a real problem.
>
>
> > kernel/time.c |   13 ++++++++-----
> > 1 files changed, 8 insertions(+), 5 deletions(-)
> >
> > Index: linux-2.6.16-rc/kernel/time.c
> > ===================================================================
> > --- linux-2.6.16-rc.orig/kernel/time.c
> > +++ linux-2.6.16-rc/kernel/time.c
> > @@ -702,16 +702,19 @@ void set_normalized_timespec(struct time
> >  *
> >  * Returns the timespec representation of the nsec parameter.
> >  */
> > -inline struct timespec ns_to_timespec(const nsec_t nsec)
> > +struct timespec ns_to_timespec(const nsec_t nsec)
> > {
> >        struct timespec ts;
> >
> > -       if (nsec)
> > +       if (nsec) return (struct timespec){0, 0};
>
>
> Err, you mean propably
>
> 	if(!nsec)
> 		return (struct timespec){0, 0};

Why yes I do.  I even found that and fixed it, but then failed to refresh the 
patch.  Thanks...

--
George Anzinger   george@xxxxxxxxxx
HRT (High-res-timers):  http://sourceforge.net/projects/high-res-timers/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/