Re: ntohs/ntohl and bitops

[David S. Miller]

From: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
Date: Wed, 11 Jan 2006 09:13:11 +0100

> > The first suggestion isn't considered ugly, and the best form is:
> > 
> > 	if (ih->frag_off & __constant_htons(IP_OFFSET))
> 
> why this __constant_htons and not just plain htons ??
> htons() gets auto-remapped to that anyway via the builtin "is this a
> constant" thing...... and to be honest htons() is more readable.

You're right.

We use the __constant_*() things for structure initialization
which needs to be compile time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/