Re: [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64

[Bryan O'Sullivan]

On Thu, 2006-01-12 at 02:33 +0100, Andi Kleen wrote:

> I think it's deeply wrong to reuse names of standard functions with different
> arguments. Either pass bytes or give it some other name.

Someone (Matt Mackall?) suggested naming it __iowrite32_copy, by analogy
with the stuff in asm-generic/iomap.h, I presume.  Would that suit you?

> That sounds like a very chipset specific assumption. Is that safe
> to make?

I can fix the doc so that it says "at least 32 bits", in that case.
This should make the assumption more clear for other bus types.

	<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/