Re: [PATCH 1/3] msi vector targeting abstractions
From: Paul Mackerras
Date: Thu Jan 12 2006 - 00:46:24 EST
Grant Grundler writes:
> > + if ((status = msi_arch_init()) < 0) {
>
> Willy told me I should always complain about assignment in if() statements :)
We are getting incredibly politically correct these days, aren't we.
I see nothing wrong with that if statement. It's perfectly valid,
idiomatic C. You can ignore Willy if you like. :)
(I would look askance at something that did an assignment as one of
the parameters of a procedure call in an if statement, though.)
Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/