Re: [PATCH 15/15] kconf: Check for eof from input stream.

[Ben Collins]

On Thu, 2006-01-12 at 13:48 +0100, Roman Zippel wrote:
> Hi,
> 
> On Thu, 12 Jan 2006, Ben Collins wrote:
> 
> > > silentoldconfig gives you exactly the same information. Both conf and 
> > > oldconfig will change invisible options without telling you, so it's not 
> > > exact at all.
> > > If you can't trust a silent oldconfig, a more verbose oldconfig can't tell 
> > > you anything else, if it would it's a bug.
> > 
> > silentoldconfig tells you a lot less, agreed?
> 
> No.

So you are saying that silentoldconfig outputs no less information than
oldconfig? No output compared to a full config output (yes, with some
special cased invisible options, but the same output that a user would
see if manually configuring).

My point is that you are making oldconfig and silentoldconfig operate
differently when they encounter a closed stdin. You are making them
inconsistent. And so far, you have yet to give a valid reason to do so.
I've been giving very valid reasons why they should work the same, and
why the behavior is correct for them to work that way.

What is the reason for silentoldconfig to fail in this way, and for
oldconfig not to? I suspect you have some special usage of your own for
which you depend on this functionality.

-- 
   Ben Collins <ben.collins@xxxxxxxxxx>
   Developer
   Ubuntu Linux

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/