Re: [git patches] 2.6.x net driver updates

[Linus Torvalds]

On Thu, 12 Jan 2006, Jeff Garzik wrote:
> 
> dann frazier:
>       CONFIG_AIRO needs CONFIG_CRYPTO

I think this is done wrong.

It should "select CRYPTO" rather than "depends on CRYPTO".

Otherwise people won't see it just because they don't have crypto enabled, 
which is not very user-friendly.

Btw, why are these casts there? Either the functions are of the right 
type, or they aren't. In neither case is the cast correct.

I do realize that there are comments in <net/iw_handler.h> that says that 
you should do the cast, but that's no excuse for crap or stupid code.

If it's an issue of trying to make greppable code, why not have
just the comment?

> @@ -2378,6 +2566,15 @@ static const iw_handler atmel_handler[] 
>  	(iw_handler) atmel_get_encode,		/* SIOCGIWENCODE */
>  	(iw_handler) atmel_set_power,		/* SIOCSIWPOWER */
>  	(iw_handler) atmel_get_power,		/* SIOCGIWPOWER */
> +	(iw_handler) NULL,			/* -- hole -- */
> +	(iw_handler) NULL,			/* -- hole -- */
...

Hmm?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/