Re: [PATCH] powerpc: Add support for the MPC83xx watchdog

[Kumar Gala]

On Fri, 13 Jan 2006, Andrew Morton wrote:

> Kumar Gala <galak@xxxxxxxxxxxxxxxxx> wrote:
> >
> > Added support for the PowerPC MPC83xx watchdog.  The MPC83xx has a simple
> > watchdog that once enabled it can not be stopped, has some simple timeout
> > range selection, and the ability to either reset the processor or take
> > a machine check.
> > 
> >
> > +static ushort timeout = 0xffff;
> 
> There's no such thing ;)  I'll change this to u16, OK?

There is one in include/linux/types.h, but u16 is fine.

> > +static int mpc83xx_wdt_ioctl(struct inode *inode, struct file *file,
> > +			     unsigned int cmd,
> > +	unsigned long arg)
> 
> Whitespace went nutty in various places.  I'll fix that up.  Please see the
> followup patch.

Odd, no one else has had any issues with patches from me recently.

- kumar

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/