Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
From: Alan Cox
Date: Sat Jan 14 2006 - 14:19:18 EST
Some quick comments:
+ if (len) {
+ epx_c3_pet();
+ }
Doesn't need brackets (minor style)
Otherwise it looks excellent but should use request_region and friends
to claim the two ports it uses.
The see the "Sign your work:" bit of Documentation/SubmittingPatches are
it looks ready to go in.
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/