Re: [PATCH 06/16] Mark Typhoon cards as Lifeview OEM's

[Mauro Carvalho Chehab]

Peter,

	This patch stayed for some time at CVS, the way it was commited to
-git. The changes did by nshm are trivial and generally we fold this
kind of change with the original patch, since:
	1) it is trivial;
	2) doesn't change technically;
	3) helps to keep Linux logs cleaner;
	4) it is susbystem maintainers task to make sure that patches are
correct and follows v4l and Linux CodingStyle.
	I think  the subject could be better. In fact, this patch subject
should be to add other Lifeview OEM PCI IDs. To use current naming
convention is a consequence of the patch.

Em Ter, 2006-01-24 às 21:59 +0100, Peter Missel escreveu:
> Hi Nickolay!
> 
> > 1. User should be able to find if his card is supported (no matter OEM
> > it or not) by searching his card name in CARDLIST
> 
> From my example, you should have a taster of where that would take us with the 
> popular OEM cards like LifeView's.
> You wouldn't believe just how many "brand" cards are actually made by them. 
> How many "brands" of LR50 cards does the BT878 driver record?
	We need to have just one convention. All patches should bound the
convention whatever it is. Of course, we can discuss the better
convention for board names at v4l mailing list, but, once defined, we
won't accept (or we should fix) newer patches that will not follow it.
> 
> > 2. We haven't invented better way to mark OEM cards yet.
> 
> I have made a suggestion on how to solve the naming problem - put the names 
> where they logically belong, into the PCI ID structure, not the card data 
> structure. That way, we get a 1:1 relation between each card incarnation 
> (original or OEM) and its name.
	This doesn't solve. There are several boards that don't have its own
PCI ID (They shares the original OEM vendor ID or chipset vendor ID).
Also, CARDLIST.foo are generated based on .name field at cards struct.
> 
> > But I understand your point, we can just remove that patch for now if
> > you are really against this change.
> 
> We need the patch I made because it solves an actual technical problem, and 
> I'd prefer to see it included the way I made it. Thank you.
	We have two options:

	1) Revert the patch from -git and start a discussion at V4L mailing
list about name convention. After archieving an agreement with this, you
can resubmit the patch, with the decided name;

	2) Keep this patch as is and start that discussion. After we archieve
an agreement, you can submit a patch just renaming it.

	As you said this patch solves a problem, I would prefer (2).
> 
> regards,
> Peter
Cheers, 
Mauro.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/