Re: [Patch] quota: fix error code for ext2_new_inode()

From: Jan Kara
Date: Wed Jan 25 2006 - 07:17:47 EST


Hi,

> the quota check in ext2_new_inode() returns ENOSPC where
> IMHO it should return EDQUOT instead. here is a trivial
> patch to fix that ...
>
> rationale: ext3, reiser, udf and ufs do similar checks
> and already return EDQUOT
Of course, you're right! Andrew please commit this one too.

Honza


> Signed-off-by: Herbert Pötzl <herbert@xxxxxxxxxxxx>
Acked-by: Jan Kara <jack@xxxxxxx>

> --- ./fs/ext2/ialloc.c.orig 2006-01-03 17:29:56 +0100
> +++ ./fs/ext2/ialloc.c 2006-01-25 07:26:42 +0100
> @@ -605,7 +605,7 @@ got:
> insert_inode_hash(inode);
>
> if (DQUOT_ALLOC_INODE(inode)) {
> - err = -ENOSPC;
> + err = -EDQUOT;
> goto fail_drop;
> }
>
>
--
Jan Kara <jack@xxxxxxx>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/