Re: [PATCH] Export symbols so CONFIG_INPUT works as a module
From: Adrian Bunk
Date: Thu Jan 26 2006 - 17:16:14 EST
On Wed, Jan 25, 2006 at 08:51:59AM +0100, Vojtech Pavlik wrote:
> On Wed, Jan 25, 2006 at 12:04:06AM -0500, Dmitry Torokhov wrote:
> > On Tuesday 24 January 2006 18:14, Martin Michlmayr wrote:
> > > * Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> [2006-01-24 18:08]:
> > > > > More interesting question: is pis^H^H^Hsysfs interaction in there safe for
> > > > > modular code?
> > > >
> > > > The core should be safe, at least I was trying to make it this way, so
> > > > if you see something wrong - shout. Locking is another question
> > > > though...
> > >
> > > So do you want an updated patch using _GPL to export the symbols or to
> > > change CONFIG_INPUT to boolean?
> >
> > I guess having input core as a module does not make much sense, so
> > we should change CONFIG_INPUT to be boolean _and_ clean up the core
> > code removing module unloading support.
>
> Well, USB or SCSI cores are also modules, so I think there is some point
> in having that functionality.
>...
The difference is that USB and SCSI are not that essential, and
therefore not always enabled if CONFIG_EMBEDDED=n. It's therefore e.g.
not uncommon that distributions offer modular USB and SCSI cores.
Are there really people building kernels for that much space limited
environments that they set CONFIG_EMBEDDED=y, and at the same time want
CONFIG_INPUT=m?
I'd have expected people using CONFIG_EMBEDDED=y to usually also set
CONFIG_MODULES=n for getting a smaller kernel.
> Vojtech Pavlik
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/