Re: [patch, lock validator] fix uidhash_lock <-> RCU deadlock

From: Linus Torvalds
Date: Fri Jan 27 2006 - 19:21:18 EST




On Thu, 26 Jan 2006, Paul E. McKenney wrote:
>
> On Wed, Jan 25, 2006 at 03:23:07PM +0100, Ingo Molnar wrote:
> > RCU task-struct freeing can call free_uid(), which is taking
> > uidhash_lock - while other users of uidhash_lock are softirq-unsafe.
>
> I guess I get to feel doubly stupid today. Good catch, great tool!!!

I wonder if the right fix wouldn't be to free the user struct early,
instead of freeing it from RCU. Hmm?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/