Re: [PATCH] libata queue updated
From: Ingo Oeser
Date: Sun Jan 29 2006 - 11:10:00 EST
Hi Jeff,
On Saturday 28 January 2006 19:25, Jeff Garzik wrote:
> Testing and merge point in Tejun's flood of patches :) The patch
> below is against current linux-2.6.git.
These "function(unsigned int *classes)" style functions in
"libata-core.c" worry me somewhat. Esp. that sometimes you have one class,
sometimes two.
This looks like a bug waiting to happen for me.
Could we somehow get a
struct ata_classes {
unsigned int master;
unsigned int slave;
}
here (or similiar), before this is in used everywhere?
Usage would be function(struct ata_classes *classes) then.
Thanks & Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/