Re: [PATCH RESEND] move swiotlb.h header file to asm-generic

[Andi Kleen]

On Monday 30 January 2006 11:01, Muli Ben-Yehuda wrote:
> On Mon, Jan 30, 2006 at 10:49:41AM +0100, Andi Kleen wrote:
> > On Monday 30 January 2006 10:44, Muli Ben-Yehuda wrote:
> > > This patch:
> > > 
> > > - creates asm-generic/swiotlb.h
> > > - makes it use 'enum dma_data_direction dir' rather than 'int dir'
> > > - updates x86-64 and IA64 to use the common swiotlb.h
> > > - fixes the resulting fall out (s/int dir/enum dma_data_direction dir/
> > >   all over the place).
> > 
> > Al Viro will likely flame you badly for that enum change. Apparently it 
> > causes some trouble in sparse. Frankly i don't see the point neither.
> > It just makes the code harder to read and creates a monstrosity of a patch 
> > and doesn't give you anything.
> 
> DMA-API.txt uses the enum form; so do arm, frv, mips, parisc and
> powerpc. x86-64, IA64, alpha, sparc, sparc64 and v850 use the int
> form. I really couldn't care less whether we use an enum or an int for
> the DMA data direction in the DMA API, as long as all archs used the
> same thing. I don't feel comfortable putting swiotlb.h in generic code
> unless it really is generic. So... which should it be?

I vote for int.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/