Re: [cdrtools PATCH (GPL)] Re: CD writing in future Linux (stirring up a hornets' nest)

From: Matthias Andree
Date: Fri Feb 03 2006 - 14:12:46 EST


Joerg Schilling schrieb am 2006-02-03:

> Matthias Andree <matthias.andree@xxxxxx> wrote:
>
> > So patches to the rescue -- please review the patch below (for 2.01.01a05).
> > Note that GPL 2a and 2c apply, so you cannot merge a modified version of
> > my patch without adding a tag that you goofed my fixes.
>
> OK, I did not look at it and I never will!

Perhaps you should -- the patch impairs your changes to get
needless device enumeration changes into the kernel...

Enforcing your strict interpretation of GPL v2 §§ 2a, 2c to the letter
was your own idea. I had to touch "modification prohibited" sections to
remove obsolete (bogus) warnings.

I'll amend the license: Show me your integrated patch. If it works
properly on my computer and without false warnings, you add a note to
the changelog and the AN-2.01.01a06 file, I will demote the patch's
license to the MIT license as in
<http://opensource.org/licenses/mit-license.php>. Yes, this is a license
contract offer as per the BGB. Just write you're accepting it, or accept
implicitly by sending the integration patch against 2.01.01a05.

I just want to make sure that it doesn't bear my name if the integration
breaks it again.

The code can probably be simplified even more with readdir() on /dev and
filtering it (avoiding glob() buffer issues), my patch doesn't even
attempt to do that.

And if you explain the use of LF_ATA, the kernel drivers might even be
fixes so that /dev/hd* looks confusably similar to /dev/sg*.

--
Matthias Andree
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/