[PATCH] no need to check pointers passed to vfree for NULL in sound/drivers/vx/vx_pcm.c

From: Jesper Juhl
Date: Sat Feb 04 2006 - 15:24:03 EST


It's pointless checking pointers about to be passed to vfree() for NULL.


Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
---

sound/drivers/vx/vx_pcm.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)

--- linux-2.6.16-rc2-git1-orig/sound/drivers/vx/vx_pcm.c 2006-02-04 14:44:23.000000000 +0100
+++ linux-2.6.16-rc2-git1/sound/drivers/vx/vx_pcm.c 2006-02-04 21:23:26.000000000 +0100
@@ -98,10 +98,9 @@ static int snd_pcm_alloc_vmalloc_buffer(
static int snd_pcm_free_vmalloc_buffer(struct snd_pcm_substream *subs)
{
struct snd_pcm_runtime *runtime = subs->runtime;
- if (runtime->dma_area) {
- vfree(runtime->dma_area);
- runtime->dma_area = NULL;
- }
+
+ vfree(runtime->dma_area);
+ runtime->dma_area = NULL;
return 0;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/