[RFC] swsusp: finally solve mysqld problem

From: Pavel Machek
Date: Sun Feb 05 2006 - 06:47:54 EST


Move userland freezing into more logical place. It now hits even with
mysqld running.

(Rafael, I'm a bit afraid this will clash with your refrigerator
changes, plus I'm lazy and don't -mm here. Do you think you could
forward it to akpm?)

Signed-off-by: Pavel Machek <pavel@xxxxxxx>

diff --git a/arch/i386/kernel/signal.c b/arch/i386/kernel/signal.c
index 963616d..5917835 100644
--- a/arch/i386/kernel/signal.c
+++ b/arch/i386/kernel/signal.c
@@ -582,9 +582,6 @@ static void fastcall do_signal(struct pt
if (!user_mode(regs))
return;

- if (try_to_freeze())
- goto no_signal;
-
if (test_thread_flag(TIF_RESTORE_SIGMASK))
oldset = &current->saved_sigmask;
else
@@ -613,7 +610,6 @@ static void fastcall do_signal(struct pt
return;
}

-no_signal:
/* Did we come from a system call? */
if (regs->orig_eax >= 0) {
/* Restart the system call - no handlers present */
diff --git a/arch/x86_64/kernel/signal.c b/arch/x86_64/kernel/signal.c
index 5876df1..e5f5ce7 100644
--- a/arch/x86_64/kernel/signal.c
+++ b/arch/x86_64/kernel/signal.c
@@ -443,9 +443,6 @@ int do_signal(struct pt_regs *regs, sigs
if (!user_mode(regs))
return 1;

- if (try_to_freeze())
- goto no_signal;
-
if (!oldset)
oldset = &current->blocked;

@@ -463,7 +460,6 @@ int do_signal(struct pt_regs *regs, sigs
return handle_signal(signr, &info, &ka, oldset, regs);
}

- no_signal:
/* Did we come from a system call? */
if ((long)regs->orig_rax >= 0) {
/* Restart the system call - no handlers present */
diff --git a/kernel/signal.c b/kernel/signal.c
index b373fc2..50eb4f5 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1922,6 +1922,8 @@ int get_signal_to_deliver(siginfo_t *inf
sigset_t *mask = &current->blocked;
int signr = 0;

+ try_to_freeze();
+
relock:
spin_lock_irq(&current->sighand->siglock);
for (;;) {
@@ -2307,7 +2309,6 @@ sys_rt_sigtimedwait(const sigset_t __use

timeout = schedule_timeout_interruptible(timeout);

- try_to_freeze();
spin_lock_irq(&current->sighand->siglock);
sig = dequeue_signal(current, &these, &info);
current->blocked = current->real_blocked;

--
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/