Re: [RFC][PATCH] unify pfn_to_page [25/25] sparc64pfn_to_page/page_to_pfn

[David S. Miller]

From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Date: Mon, 06 Feb 2006 20:23:33 +0900

> --- cleanup_pfn_page.orig/arch/sparc64/mm/init.c
> +++ cleanup_pfn_page/arch/sparc64/mm/init.c
> @@ -320,16 +320,6 @@ void __kprobes flush_icache_range(unsign
>   	}
>   }
> 
> -unsigned long page_to_pfn(struct page *page)
> -{
> -	return (unsigned long) ((page - mem_map) + pfn_base);
> -}
> -
> -struct page *pfn_to_page(unsigned long pfn)
> -{
> -	return (mem_map + (pfn - pfn_base));
> -}
> -
>   void show_mem(void)
>   {
>   	printk("Mem-info:\n");

We did not want these inlined on sparc64 for a good reason.
The pointer arithmatic gets expanded to many additions,
subtractions, and shifts, and I felt it too much to inline.

If you want to consolidate all of the implementations, that's
fine, but please keep the option of not inlining these two
routines.

Thank you.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/