Re: [ck] Re: [PATCH] mm: implement swap prefetching

[Con Kolivas]

On Tue, 7 Feb 2006 12:29 pm, Con Kolivas wrote:
> On Tue, 7 Feb 2006 11:38 am, Andrew Morton wrote:
> > Con Kolivas <kernel@xxxxxxxxxxx> wrote:
> > > +	if (unlikely(!spin_trylock(&swapped.lock)))
> > > +		goto out;
> >
> > hm, spin_trylock() should internally do unlikely(), but it doesn't. 
> > (It's a bit of a mess, too).
>
> Good point. Perhaps I should submit a separate patch for this instead.

A quick look at this code made me change my mind; there's heaps that could do 
with this treatment in spinlock.h. I'll let someone else tackle it.

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/