Re: [SCSI] fix wrong context bugs in SCSI

From: James Bottomley
Date: Tue Feb 07 2006 - 18:24:58 EST


On Tue, 2006-02-07 at 16:05 -0600, Brian King wrote:
> I just tried this out on my ppc64 box. I recently noticed that
> the target reaping via workqueue change that went in not too long ago
> resulted in *really* slow user initiated wildcard scans for ipr
> adapters - in the neighborhood of 6 minutes... Your patch brings
> that back down to 8 seconds.

Yes, that's because the original fix used a workqueue for everything
(whether it needed it or not). The new API checks the context first
before invoking a workqueue. By and large, for SCSI, we actually have
user context most of the time, so the old fix was rather heavy handed.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/