Re: [PATCH 7/8] don't mangle INQUIRY if cmddt or evpd bits are set

[Al Viro]

On Wed, Feb 08, 2006 at 11:35:18PM +0100, Stefan Richter wrote:
> I tested the patch with 8 different SBP-2 bridges, based on 6 or 7 
> different bridge chips. Works for me.
> 
> In fact, not a single one of these bridges is affected by the code 
> change since the additional expression which was added always evaluates 
> true.

The hell it does.  Try scsiinfo -s and you'll see.  All INQUIRY generated
by scsi midlayer have both flags set to 0.  Userland ones do not; example
I've mentioned (scsiinfo -s) will send an INQUIRY with EVPD=1 and page
code 0x80 (that's cmnd[2]), which results in response of form
	(periph_qualifier << 5) | device_type
	0x80
	<reserved>
	page length
	unit serial number (page length - 3 bytes)

Similar for page 0x83 (device identification descriptors), etc.  Userland
gets to those via SG_IO and yes, it's really used.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/