Re: 2.6.16-rc2-mm1 -- BUG: warning at drivers/ieee1394/ohci1394.c:235/get_phy_reg()

[Stefan Richter]

Andrew Morton wrote:
> Miles Lane <miles.lane@xxxxxxxxx> wrote:
> > BUG: warning at drivers/ieee1394/ohci1394.c:235/get_phy_reg()
>
> That's a -mm-only warning telling you that get_phy_reg() is doing a
> one-millisecond-or-more busywait while local interrupts are disabled.

Same with set_phy_reg, ohci_soft_reset, ohci_hw_csr_reg. At least the 
callers of ohci_hw_csr_reg (in particular, csr_highlevel.host_reset, 
furthermore csr_highlevel.add_host) could fairly easily be converted to 
a workqueue job or perhaps moved to the nodemgr thread. I have not 
checked the other offending functions yet.
--
Stefan Richter
-=====-=-==- --=- -=-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/