Re: [PATCH 02/13] hrtimer: remove useless const

[Andrew Morton]

Roman Zippel <zippel@xxxxxxxxxxxxxx> wrote:
>
> Hi,
> 
> On Mon, 13 Feb 2006, Ingo Molnar wrote:
> 
> > your patch makes code larger on gcc3. Please investigate why.
> 
> Ok, I checked with 3.3.6 and 3.4.5 and adding const to ktime_divns/ 
> posix_cpu_nsleep fixes the problem (actually the kernel becomes even 
> smaller because posix_cpu_clock_getres is better off without const), both 
> are complex and noncritical functions.
> Andrew, I'd really prefer to keep the patch and I'll send a patch to add 
> the const where it's actually an improvement.
> 

There's been enough churn here that it'll be counterproductive for me to
continue to munge on your patches.  I'll drop the lot and will await rev
#2.

I don't think any of this was critical for 2.6.16.  If there's something
which you really do think needs to be in 2.6.16 then please carefully
describe the reasons for that, and make sure that the most critical
patches are staged at the head of the series.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/