Re: [PATCH 00/12] hrtimer patches

[Ingo Molnar]

* Roman Zippel <zippel@xxxxxxxxxxxxxx> wrote:

> > > Here is new version of the hrtimer patches sorted by priority. I 
> > > dropped the remaining time patch, the const patch doesn't produce a 
> > > larger kernel with gcc3 and I also added the acks so far. I consider 
> > > the first four patches the most important and the remaining patches 
> > > simple enough, that I think they're still 2.6.16 material.
> > 
> > i only consider the first two patches to be 2.6.16 material. The other 
> > patches avoid a ->get_time() call per timer interrupt - that's noise at 
> > most ...
> 
> It's two get_time() calls and I don't consider it noise, they are 
> wasting time with unnecessary hardware accesses.

Nobody complained about it so far (other than you) or has measured it, 
so IMO there's no pressing need and it's simply too late in the cycle to 
touch core timer code like that. 2.6.16 is really cooling down now.

Furthermore, this is known subtle code, and it has accumulated some good 
QA by now. Your first patch-queue already introduced races (the 
"optimize hrtimer_get_remaining" patch) - which you considered to be
part of the "minimum amount of patches for 2.6.16" too.

Dont take this as some negative feedback: most of them look fine to me,
and it's really great that you are contributing to the code, but please
be a bit more patient.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/