Re: [PATCH 4/8] block: convert IDE to use blk_kmap helpers

[Russell King]

On Wed, Feb 15, 2006 at 11:05:02AM +0900, Tejun Heo wrote:
> Matt Reimer wrote:
> >On 1/13/06, Tejun Heo <htejun@xxxxxxxxx> wrote:
> >
> >>Convert direct uses of kmap/unmap to blk_kmap/unmap in IDE.  This
> >>combined with the previous bio helper change fixes PIO cache coherency
> >>bugs on architectures with aliased caches.
> >>
> >>Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
> >
> >
> >This series of patches makes booting from CF on my PXA255 device. Thanks 
> >Tejun.
> >
> >Will these patches make 2.6.16?
> >
> 
> Unfortunately, this patchset has some pending issues and probably should 
> be spinned one more time with another approach, although I'm currently 
> not very sure what the another approach should be.  :-(
> 
> I'll try to do something.  Thanks.

I think that's a mistake.  Yes, James has decided to object, but I
think that James' objections are unfounded.

Since James doesn't even have a machine which shows this bug, it's
rather convenient for him to object and effectively stand in the way
of having the bug being fixed.

Or that's how I'm reading the current impass on these patches.

Linus - can we merge Tejun's patches so that we have an IDE subsystem
which works on ARM platforms please?  If James wants to come up with
another solution later on, I'm sure we can transition all drivers
over to that new solution once we know what it is.  Until then, can
we please fix the bug?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/