Re: [ck] [PATCH] mm: implement swap prefetching (v26)

[Con Kolivas]

On Saturday 18 February 2006 01:18, Kevin Radloff wrote:
> On 2/17/06, Con Kolivas <kernel@xxxxxxxxxxx> wrote:
> > Added disabling of swap prefetching when laptop_mode is enabled.
>
> Why bother with this? As someone commented in a previous thread,
> wouldn't it be better to let the laptop_mode script handle it?

The discussion was about what size to make the swap prefetching. Since the 
size is not user tunable any more that is not the case. I had an offlist 
discussion with Bart Samwel about it and basically if your drive spins down 
at 5 seconds (which is what commonly happens with laptop mode) you will never 
have an opportunity to prefetch. This means swap prefetch will basically 
always spin up the drive nullifying laptop mode. On balance if you care about 
power more than anything to actually set laptop mode I suspect you wont want 
prefetch using any more power.

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/