Re: [PATCH] sym53c8xx_2: Add bios_param to sym_glue.c

[Seewer Philippe]

Matthew Wilcox wrote:
> On Fri, Feb 17, 2006 at 03:10:43PM +0100, Seewer Philippe wrote:
> 
>>This patch adds the scsi common function bios_param to the sym53c8xx
>>driver. For simplicity i just copied the code from the sym53c416 driver.
> 
> 
> If the driver doesn't define bios_param, the scsi core calls
> scsicam_bios_param, which seems to do everything this patch does,
> and more.
> 
> A quick survey suggests that most drivers should have their bios_param
> methods deleted.  Was there a particular problem you found with the
> default scsicam_bios_param implementation?
Yes. Using scsicam_bios_parm and other defaults result in a geometry of
64 heads and 32 sectors even for big disks, which is not what the pc bios
"gets" from the controller. That is more along the lines of 255/63.

Returning a geometry of x/255/63 seems to be the default for bigger disks
withing scsi drivers, so i just copied the code...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/