Re: [PATCH: 005/012] Memory hotplug for new nodes v.2.(pgdat alloccaller for x86-64)

[Dave Hansen]

On Fri, 2006-02-17 at 22:29 +0900, Yasunori Goto wrote:
> +       zone_type = start_pfn < MAX_DMA32_PFN ?
> +                   ZONE_DMA32 : ZONE_NORMAL; 

Please change this to something which we can more easily parse, such as
this:

	if (start_pfn < MAX_DMA32_PFN)
		zone_type = ZONE_DMA32;
	else
		zone_type = ZONE_NORMAL;

I think it is worth the extra two lines.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/