Re: [PATCH] SIIG 8-port serial boards support

[Russell King]

On Fri, Feb 17, 2006 at 08:02:13PM +0000, Russell King wrote:
> On Fri, Feb 17, 2006 at 02:39:42PM +0300, Andrey Panin wrote:
> > On 034, 02 03, 2006 at 09:24:36 +0000, Russell King wrote:
> > > On Fri, Feb 03, 2006 at 12:13:08PM +0300, Andrey Panin wrote:
> > > > On 033, 02 02, 2006 at 08:17:35 +0000, Russell King wrote:
> > > > > As I've said many a time, we need a generic way to set different hand-
> > > > > shaking modes.  I've suggested using some spare bits in termios in the
> > > > > past, but nothing ever came of that - folk lose interest at that point.
> > 
> > No wonder they do. Extra bits are not a problem, but for 8250.c we need some
> > way to glue subdrivers with serial8250_set_termios(). Callback in uart_port
> > structure ?

Finally, let me explain why I favour the termios solution.  The biggest
(and most important) aspect is that it allows existing applications
such as minicom and gettys to work as expected - getting the correct
handshaking mode that they desire without having to change userspace.

I think that is an _extremely_ important property to have.  Without it,
you would end up with (eg) a security issue where a user changes the
handshaking mode of the dial-up connection they're on, rendering it
useless until the sysadmin "undoes" the damage.

Alternatively, every serial line getty at least needs to be taught
how to reset the handshaking mode, which at present means that it
needs to be taught about the hardware cards so it knows what silly
random ioctl call for some proprietary method to make.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/