Re: [PATCH 1/5] [pm] Fix locking of device suspend/resume functions
From: Patrick Mochel
Date: Sat Feb 18 2006 - 00:48:45 EST
On Fri, 17 Feb 2006, Andrew Morton wrote:
> Patrick Mochel <mochel@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > This patch removes the unneeded down()/up() calls from
> > suspend_device() and resume_device(). Those functions
> > are already called under the dpm_sem, making this code
> > unconditionally deadlock in SMP kernels.
>
> I've seen no reports of such deadlocks. And I was testing swsusp on a
> 4-way this week?
Yup, I misparsed the code. Please disregard this patch.
Thanks,
Pat
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/