Re: [PATCH 2/2] fix kill_proc_info() vs fork() theoretical race
From: Oleg Nesterov
Date: Sat Feb 18 2006 - 11:59:42 EST
"Paul E. McKenney" wrote:
>
> On Fri, Feb 17, 2006 at 12:20:08AM +0300, Oleg Nesterov wrote:
> > "Paul E. McKenney" wrote:
> > >
> > > The other thing to think through is tkill on a thread/process while it
> > > is being created. I believe that this is OK, since thread-specific
> > > kill must target a specific thread, so does not do the traversal.
> >
> > Also, tkill was not converted to use rcu_read_lock yet, it still
> > takes tasklist_lock, so I think it is safe.
>
> I suspect that tkill will eventually need to avoid tasklist_lock... ;-)
Ok, I am sending a couple of preparation patches for this.
Paul, I didn't beleive you when you started this work. Now I think
we can avoid tasklist AND cleanup the code in many places. I am glad
I was wrong.
Btw,
>
> firing off some steamroller tests on it.
Could you point me to these tests?
Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/