Re: [PATCH] Fix undefined symbols for nommu architecture

[Andrew Morton]

"Luke Yang" <luke.adi@xxxxxxxxx> wrote:
>
> Hi,
> 
>   This is a patch to add or export some undefined symbols in nommu
> architectures (mm/nommu.c).  Based on latest mm-tree. Following
> symbols are added: vmap, vunmap, randomize_va_space.
> 
> Signed-off-by: Luke Yang <luke.adi@xxxxxxxxx>
> 
> Index: git/linux-2.6/mm/nommu.c
> ===================================================================
> --- git.orig/linux-2.6/mm/nommu.c	2006-02-17 17:40:34.000000000 +0800
> +++ git/linux-2.6/mm/nommu.c	2006-02-20 12:09:32.000000000 +0800
> @@ -57,7 +57,10 @@
>  EXPORT_SYMBOL(vfree);
>  EXPORT_SYMBOL(vmalloc_to_page);
>  EXPORT_SYMBOL(vmalloc_32);
> +EXPORT_SYMBOL(vmap);
> +EXPORT_SYMBOL(vunmap);

OK.

> +int randomize_va_space = 0;

Not so sure about this one.  Does randomize_va_space actually make sense in
a nommu environment?  I guess we could load relocatable binaries into a
randomised place, but I'm not sure that this is implemented?

If no, then it would make more sense to do

	#define randomize_va_space 0

for nommu, so the relevant code gets thrown away by the compiler.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/