Re: Which is simpler? (Was Re: [Suspend2-devel] Re: [ 00/10] [Suspend2] Modules support.)

From: Nigel Cunningham
Date: Mon Feb 20 2006 - 06:44:35 EST


Hi.

On Monday 20 February 2006 20:02, Lee Revell wrote:
> On Mon, 2006-02-20 at 10:39 +0100, Matthias Hensler wrote:
> > > It is slightly slower,
> >
> > Sorry, but that is just unacceptable.
>
> Um... suspend2 puts extra tests into really hot paths like fork(), which
> is equally unacceptable to many people.

It doesn't.

Fork is only a 'really hot path' if you have a fork bomb running. The
scheduler is a really hot path (which Suspend2 patches don't touch, by the
way).

The change in the page allocation routine follows a comment saying "This is
the last chance, in general, before the goto nopage." It adds one further
test to the four already done at that point.

Regards,

Nigel

--
See our web page for Howtos, FAQs, the Wiki and mailing list info.
http://www.suspend2.net IRC: #suspend2 on Freenode

Attachment: pgp00000.pgp
Description: PGP signature