Re: [PATCH] autofs4 - fix comms packet struct size

[Christoph Hellwig]

On Mon, Feb 20, 2006 at 09:05:59AM +0800, Ian Kent wrote:
> > >  	autofs_wqt_t wait_queue_token;
> > 
> > Hiding types in user visible structures behind typedefs is bad.
> > What type is behind this?  If this is not an __u32 you have
> > a padding issue.
> 
> This has been an occassion problem for a long time.
> Since it dates back to way before version 4 I have always been reluctant 
> to change it. I'd rather leave it as is unless you really can't accept it.

So is this an __u32? ;-)

> OK. But will they be 32 bit for the life of this struct?

If we'd ever bump pid_t or uid_t to 64bits tons of kernel interface
would need to change.  And no one guarantees it'd be come an u64
then.  So __u32 is the safest choice.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/